Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature: Print breakpoint table #61

Merged
merged 6 commits into from
Sep 11, 2022
Merged

Add feature: Print breakpoint table #61

merged 6 commits into from
Sep 11, 2022

Conversation

yihuajack
Copy link
Collaborator

Take example5.evcd, breakpoints=[9,11,17] as example, the table is:

time    9       11      17
scope   testbench
scope   pe8
req_I   128     16      4
req_O   zzzzzzzz        zzzzzzzz        zzzzzzzz
en_I    1       1       1
en_O    z       z       z
scope   pe4
req_I   8       4       2
req_O   zzzz    zzzz    zzzz
en_I    1       1       1
en_O    z       z       z

@yihuajack yihuajack added the enhancement New feature or request label Sep 5, 2022
@yihuajack
Copy link
Collaborator Author

The column width of tables can be fine-adjusted, but to achieve it, sootty needs to recursively see all the wires twice, so performance is lost.

Ben1152000
Ben1152000 requested changes Sep 7, 2022
View reviewed changes
sootty/storage/wiregroup.py Outdated Show resolved Hide resolved
sootty/storage/wiregroup.py Show resolved Hide resolved
@Ben1152000
Copy link
Owner

Have you tested if this works when the waveform is being displayed? The svg is written to stdout and piped to the display program, so if the breakpoints are also printed to stdout that could possibly break the image.

@yihuajack
Copy link
Collaborator Author

Have you tested if this works when the waveform is being displayed? The svg is written to stdout and piped to the display program, so if the breakpoints are also printed to stdout that could possibly break the image.

Yes, I've tested that this works with or without -o, but I'm not quite familiar with subprocess. What if subprocess.run is used instead of subprocess.Popen()?

Ben1152000
Ben1152000 approved these changes Sep 11, 2022 •
edited
Loading
View reviewed changes
@Ben1152000 Ben1152000 self-requested a review September 11, 2022 00:31
Ben1152000
Ben1152000 approved these changes Sep 11, 2022
View reviewed changes
sootty/storage/wiregroup.py Outdated Show resolved Hide resolved
@yihuajack yihuajack merged commit f2153a9 into Ben1152000:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ben1152000 Ben1152000 Ben1152000 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuajack @Ben1152000